-
-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip write to 'name' property if not [[writable]] #2304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request to fix this issue 💯
I have a couple of stylistic suggestions, trying out the multiline suggestions feature in the process.
Co-authored-by: Morgan Roderick <20321+mroderick@users.noreply.github.com>
Co-authored-by: Morgan Roderick <20321+mroderick@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've committed the changes - thanks for the feedback 👍🏾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~ Linted ~
This has been published with |
Purpose
Fix issue #2203 by skipping 'name' property if it is not [[writable]].
Solution
This solution works by skipping writing a source property to the target object if the property is 'name' and is not [[writable]] on the 'target'.
How to verify
npm install
npm test
Checklist for author
npm run lint
passes